search

ietf-ribose / bibxml-service

Django-based Web service implementing IETF BibXML APIs
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Deployment should only work on pushing of certain tags? #3

Open ronaldtse opened 2 years ago

ronaldtse commented 2 years ago

Right now, pushing any tag will result in deployment. However, we probably only want pushing a certain type of tag, e.g. 'v1.0' to trigger deployment? If someone pushes an old tag, the deployment will happen as well and that is not desired.

https://github.com/ietf-ribose/bibxml-service/blob/131d6f74bf695c399805cf171d35247ea4970c35/.github/workflows/main.yml#L6

strogonoff commented 2 years ago

I support this, this helps avoid situations where someone pushes a change but forgets to increment version. Version is shown in GUI and people may rely on it in some cases, so it’s undesirable.

strogonoff commented 2 years ago

relaton-py does it this way, but this service doesn’t use the v prefix for tags.

strogonoff commented 2 years ago

One problem here is that I don’t think Git tags are included in the PR. This creates a situation where we may have different version numbers on staging and production.

strogonoff commented 2 years ago

edit: Which may be OK? Given our versions are essentially dates.