search

ietf-ribose / github-migration-project

Subversion to Git migration tooling
1 stars 0 forks source link

Deliverable: New GitHub repository for Mailarchive correctly populated with migrated data from Trac and Subversion. #2

Closed ronaldtse closed 2 years ago

ronaldtse commented 3 years ago

Trac tickets and SVN data available now at:

@rjsparks this repo is ready for review.

rjsparks commented 3 years ago

This one has issues. There are thousands of closed issues that aren't things that should have landed in this repo (they appear as things like Not available in trac 1 closed.

All of the closed issues appear to be closed on the same time - basically when the conversion was run (and I see this affects the other repositories too, so this is a global issue).

ronaldtse commented 3 years ago

@rjsparks the closed tickets are used to maintain the ID to ID mapping between Trac tickets and GitHub issues, as previously discussed.

If we don't want the one to one ID mapping, it's just an option to switch off in Tractive.

rjsparks commented 3 years ago

@rjsparks the closed tickets are used to maintain the ID to ID mapping between Trac tickets and GitHub issues, as previously discussed.

If we don't want the one to one ID mapping, it's just an option to switch off in Tractive.

The one-one mapping is valuable - we'll deal with cleaning the not availbles after.

Just to make sure it wasn't lost - note the concern about all closed tickets (not just the ones that say "not available") having the same time instead of the time they were actually closed.

ronaldtse commented 3 years ago

Got it, so we will retain the one-to-one mapping -- but please feel free to suggest any changes to those placeholder messages to make them clearer.

Sorry for missing a reply on the "closed ticket time" part. Actually we wanted to do some research about it before getting back to you on it.

In particular, it might be possible that GitHub can accept the original closure time, we just need to try.

The relevant code in Tractive is (courtesy of @HassanAkbar ):

https://github.com/ietf-ribose/tractive/blob/212ea5b5649376a3b19e01004d054912a996e099/lib/tractive/migrator/engine.rb#L106

HassanAkbar commented 3 years ago

I have verified that the original time of closure can be added to the tickets. I will update the tractive code to include the actual closed time for tickets.

@rjsparks For the closed tickets added to maintain ID to ID mapping between Trac tickets and GitHub issues, do we want to add any specific closed time (that might help in filtering such issues)?

rjsparks commented 3 years ago

last unix epoch-ish perhaps?

rjsparks commented 3 years ago

please feel free to suggest any changes to those placeholder messages to make them clearer. How about "Placeholder issue #{ticket_id} created to align github issue and trac ticket numbers during migration."

And after the migration's done - what would the consequence of deleting those things be?

ronaldtse commented 3 years ago

@rjsparks GitHub doesn't allow "deletion" of issues, only "closure".

rjsparks commented 3 years ago

image

ronaldtse commented 3 years ago

@rjsparks wow that's a (not so new) feature I never knew about! Thanks...

Since 2018-11-08: https://hub.packtpub.com/github-now-allows-repository-owners-to-delete-an-issue-curse-or-a-boon/

ronaldtse commented 3 years ago

Here's my experiment.

  1. I created 3 issues
Screenshot 2021-12-03 at 10 46 09 PM
  1. Deleted 1
Screenshot 2021-12-03 at 10 46 24 PM
  1. Created a new issue, which got assigned as 4, which is correct.
Screenshot 2021-12-03 at 10 47 32 PM

  1. Deleted 3

  2. Created new issue, which is assigned 5, correct.

  3. See if I can still refer back to the deleted issues 1 and 3, which I couldn't, and that is correct.

Screenshot 2021-12-03 at 10 49 01 PM

So I don't think there would be any particular drawbacks.

HassanAkbar commented 2 years ago

@ronaldtse this is also done.

ronaldtse commented 2 years ago

Thanks!