search

ietf-tools / bibxml-service

Django-based Web service implementing IETF BibXML APIs
https://bib.ietf.org
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

fix(xml2rfc): don't treat subseries ID as RFC ID #291

Closed strogonoff closed 2 years ago

strogonoff commented 2 years ago

fix #260

strogonoff commented 2 years ago

Evidently the CI error is not related to the change.

kesara commented 2 years ago

Evidently the CI error is not related to the change.

@strogonoff, We might have to update the CI tests to show the actual errors. I ran it locally, logs were written to ./test-artifacts/stderr.log.

See https://github.com/ietf-tools/bibxml-service/pull/291#pullrequestreview-1095783929

strogonoff commented 2 years ago

Looks like rfcs_ref should be rfcsubseries_ref in the test?

strogonoff commented 2 years ago

Yes, looks like tests are broken, implementation correct

strogonoff commented 2 years ago

@kesara Let’s merge these changes now—tests are going to be updated in another PR.