search

ietf-tools / bibxml-service

Django-based Web service implementing IETF BibXML APIs
https://bib.ietf.org
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

ci: Pass CODECOV_TOKEN in docker-compose.test.yml #440

Closed kesara closed 4 months ago

microamp commented 4 months ago

Alternatively, we can modify .github/workflows/tests.yml to include PRs along with the main branch.

kesara commented 4 months ago

Alternatively, we can modify .github/workflows/tests.yml to include PRs along with the main branch.

The GHA is already configured to run on tests with pull_request trigger and this change makes sure CODECOV_TOKEN gets passed to the docker instance that runs tests and uploads coverage to codecov.

microamp commented 4 months ago

Update: After merging this PR, I rebased the main branch into the test/serializers branch here, https://github.com/ietf-tools/bibxml-service/pull/439.

However, I can see that that hasn't fixed the issue. https://github.com/ietf-tools/bibxml-service/actions/runs/9950576461/job/27488655210?pr=439#step:7:302