search

ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
591 stars 359 forks source link

ScheduledSession objects aren't getting removed when they should #1498

Closed ietf-svn-bot closed 10 years ago

ietf-svn-bot commented 10 years ago

resolution_fixed type_defect | by rjsparks@nostrum.com

At some point when sessions are rescheduled (moved from one timeslot to another), the initial scheduledsession object is not getting cleaned up correctly. This is probably happening when the session is being moved out of a timeslot that has more than one Session currently associated with it.

The result violates the expectations of the UI code, which begins showing other ScheduledSession entries for the affected group as extended when it shouldn't be, and the improper scheduledsession object is used in calculating conflicts, even though it's not displayed for a timeslot.

A patch for removing the bad objects is in patches/2014-10-06-fix-91-scheduledsessions.py. If you need to run it again, sanity check it first by commenting out the .delete() and make sure what it's going to do looks sane.

Today's run produced:

Removing [<ScheduledSession: IETF-91:honolulu-10-6(Stephanie McCammon) [IETF-91: siprec 0900[23492]<->91: 11-13 16:30-19:00 Afternoon Session III, South Pacific 1]>]
Removing [<ScheduledSession: IETF-91:honolulu-10-6(Stephanie McCammon) [IETF-91: dice 1520[23500]<->91: 11-12 15:20-16:50 Afternoon Session II, Coral 2]>, <ScheduledSession: IETF-91:honolulu-10-6(Stephanie McCammon) [IETF-91: dice 1520[23500]<->91: 11-13 16:30-19:00 Afternoon Session III, Hibiscus K Tower]>]
Removing [<ScheduledSession: IETF-91:honolulu-10-6(Stephanie McCammon) [IETF-91: tictoc 1520[23515]<->91: 11-11 13:00-15:00 Afternoon Session I, Hibiscus K Tower]>]
Removing [<ScheduledSession: IETF-91:post-bof(Stephanie McCammon) [IETF-91: siprec 0900[23492]<->91: 11-13 16:30-19:00 Afternoon Session III, South Pacific 1]>]
Removing [<ScheduledSession: IETF-91:post-bof(Stephanie McCammon) [IETF-91: tictoc 1520[23515]<->91: 11-11 13:00-15:00 Afternoon Session I, Hibiscus K Tower]>]
Removing [<ScheduledSession: IETF-91:post-bof2(Stephanie McCammon) [IETF-91: siprec 0900[23492]<->91: 11-13 16:30-19:00 Afternoon Session III, South Pacific 1]>]
Removing [<ScheduledSession: IETF-91:post-bof2(Stephanie McCammon) [IETF-91: dice 1520[23500]<->91: 11-13 16:30-19:00 Afternoon Session III, Hibiscus K Tower]>]
Removing [<ScheduledSession: IETF-91:post-bof2(Stephanie McCammon) [IETF-91: tictoc 1520[23515]<->91: 11-11 13:00-15:00 Afternoon Session I, Hibiscus K Tower]>]
Removing [<ScheduledSession: IETF-91:honolulu-10-3(Stephanie McCammon) [IETF-91: siprec 0900[23492]<->91: 11-13 16:30-19:00 Afternoon Session III, South Pacific 1]>]
Removing [<ScheduledSession: IETF-91:honolulu-10-3(Stephanie McCammon) [IETF-91: dice 1520[23500]<->91: 11-13 16:30-19:00 Afternoon Session III, Hibiscus K Tower]>]
Removing [<ScheduledSession: IETF-91:honolulu-10-3(Stephanie McCammon) [IETF-91: tictoc 1520[23515]<->91: 11-11 13:00-15:00 Afternoon Session I, Hibiscus K Tower]>]

Issue migrated from trac:1498 at 2022-03-04 03:52:33 +0000

ietf-svn-bot commented 10 years ago

@rjsparks@nostrum.com changed status from new to closed

ietf-svn-bot commented 10 years ago

@rjsparks@nostrum.com changed resolution from ` tofixed`

ietf-svn-bot commented 10 years ago

@rjsparks@nostrum.com commented

Fixed in a12be8aeb5bc23e51ee6f075047442880ff1b33b:

Removes a modify-while-iterating error, and removes a bug where two different bits of code thought they were responsible for deleting things from a global list. Fixes bug #1498. Commit ready for merge.

ietf-svn-bot commented 10 years ago

@henrik@levkowetz.com commented

Fixed in e4d43d8e52ca8cc978cd376a90c73be78df96046:

Merged in a12be8aeb5bc23e51ee6f075047442880ff1b33b from rjsparks@nostrum.com:\n Removes a modify-while-iterating error, and removes a bug where two different bits of code thought they were responsible for deleting things from a global list. Fixes bug #1498.