search

ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
594 stars 359 forks source link

uploading a txt base review mangles all the white space into gibberish #2200

Closed ietf-svn-bot closed 7 years ago

ietf-svn-bot commented 7 years ago

keyword_sprint resolution_fixed type_defect | by paul@nohats.ca

I uploaded a review based on a txt file and all the monospace formatting used got mangled. It also mangled flowed so that the entire review became an unreadable blob of text.

I've attached my text file so it can be used for testing this buf

Issue migrated from trac:2200 at 2022-03-04 05:44:36 +0000

ietf-svn-bot commented 7 years ago

@paul@nohats.ca uploaded file draft-ietf-mmusic-sctp-sdp-review.txt (7.3 KiB)

the example review txt file that got mangled

ietf-svn-bot commented 7 years ago

@rjsparks@nostrum.com commented

Just to confirm, you are pointing to what happened to the message as it went through the mail system - the formatting of the message at https://mailarchive.ietf.org/arch/msg/secdir/ea5zK5S10aL53v4wsW4xJWDpkeE is what you would like to be different.

I see that https://datatracker.ietf.org/doc/review-ietf-mmusic-sctp-sdp-22-secdir-lc-wouters-2017-02-09/00/ doesn't show me that content. It should. Instead, it's showing me the content of the revised 01 version.

The issue with mail being re-wrapped is not a new one - we've been dancing around the right balance for that for many years, with the text that Area Directors provide when placing positions on documents being the primary driving function. We'll look at the example you provide (thanks for that) and see if we can change the balance to be better than it currently is. (The thing we're balancing against are the set of people that enter text that has no line wrapping whatsoever).

ietf-svn-bot commented 7 years ago

@rjsparks@nostrum.com changed priority from n/a to medium

ietf-svn-bot commented 7 years ago

@rjsparks@nostrum.com changed keywords from ` tosprint`

ietf-svn-bot commented 7 years ago

@rjsparks@nostrum.com changed status from new to closed

ietf-svn-bot commented 7 years ago

@rjsparks@nostrum.com changed resolution from ` tofixed`

ietf-svn-bot commented 7 years ago

@rjsparks@nostrum.com commented

There have been several improvements related to this in the last few months. The online display now preserves whitespace to the extent possible, by styling the results with

white-space: pre-wrap;
word-break: keep-all;

The email that's sent also preserves whitespace, but breaks very long lines heuristically. See 1a59cf60d375f7ad7652f10d26f6bf7b32be65dd, 16d129cacfc598a4ab0f9aba40ccd7d1eaca715c, 5b2087f910ead13b3242ebb5eb1014ad5c2bd2b2, and 5ca4309691a9b7dba9473663b80d7dbb50aede7f