search

ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
588 stars 350 forks source link

Code enforcing an older convention needs to be removed #2802

Open ietf-svn-bot opened 5 years ago

ietf-svn-bot commented 5 years ago

type_defect | by rjsparks@nostrum.com

In ietf.meetings.utils.handle_upload_file, we have:

    # agendas and minutes can only have one file instance so delete file if it already exists
    if subdir in ('agenda','minutes'):
        old_files = glob.glob(os.path.join(path,base) + '.*')
        for f in old_files:
            os.remove(f)

The assertion was once true, but no longer is. We allow versioned minutes and agendas. The code isn't exercised because the filename passed in (in modern meetings) contains the revision # already.

Issue migrated from trac:2802 at 2022-03-04 07:17:32 +0000

ietf-svn-bot commented 4 years ago

@rjsparks@nostrum.com changed priority from medium to minor

ietf-svn-bot commented 4 years ago

@rjsparks@nostrum.com changed status from new to accepted