The code that handles revising assignments creates broken records

[ietf-svn-bot]

resolution_fixed type_defect | by rjsparks@nostrum.com

---

The code starting around https://trac.tools.ietf.org/tools/ietfdb/browser/tags/7.6.0/ietf/doc/views_review.py?rev=18094#L704 is creating names for documents of type review that are unexpected by the rest of the datatracker.

Instead of creating a new Document object with the extra -2, -3, etc. it should be using the rev field of the existing Document.

The review field of the corresponding ReviewAssignment object is often set to (or left at) Null when this happens, which is a bug.

Initial debugging suggests this happens when reviews are revised after they are closed.

These appear to be the affected documents:

In 3f261d9da85077dbd452ed08d6c6e08d6d076677: for name in Document.objects.filter(name__startswith='review-',reviewas
   ...: signment__isnull=True).values_list('name',flat=True):
   ...:     print(name)
   ...:
review-ietf-6lo-privacy-considerations-04-secdir-lc-kaduk-2016-11-30
review-ietf-6lo-privacy-considerations-04-secdir-lc-kaduk-2016-11-30-2
review-ietf-6lo-privacy-considerations-04-secdir-lc-kaduk-2016-11-30-3
review-ietf-emu-rfc5448bis-06-secdir-lc-rose-2020-01-27
review-ietf-netconf-yang-push-22-genart-lc-bryant-2019-04-10
review-ietf-netconf-subscribed-notifications-23-rtgdir-lc-singh-2019-04-16
review-ietf-cbor-array-tags-07-opsdir-lc-dunbar-2019-08-26-2
review-ietf-stir-passport-divert-07-opsdir-lc-dunbar-2019-12-02
review-ietf-dprive-rfc7626-bis-03-genart-lc-shirazipour-2019-12-04
review-ietf-dprive-rfc7626-bis-03-genart-lc-shirazipour-2019-12-04-2
review-ietf-mmusic-t140-usage-data-channel-11-tsvart-lc-scharf-2020-01-28
review-ietf-pim-msdp-yang-12-yangdoctors-lc-rahman-2020-01-28
review-ietf-pim-msdp-yang-12-secdir-lc-roca-2020-01-29
review-ietf-bess-nsh-bgp-control-plane-13-rtgdir-lc-singh-2020-01-29
review-ietf-6lo-minimal-fragment-09-opsdir-lc-banks-2020-01-31
review-ietf-nfsv4-rpcrdma-cm-pvt-data-06-genart-lc-nandakumar-2020-01-27
review-ietf-nfsv4-rpcrdma-cm-pvt-data-06-opsdir-lc-comstedt-2020-01-27
review-ietf-dots-architecture-15-tsvart-lc-tuexen-2020-01-27
review-ietf-capport-api-07-opsdir-lc-dunbar-2020-05-09
review-ietf-capport-architecture-08-genart-lc-halpern-2020-05-16

mysql> select id,name,time from doc_document where name like 'review-%-201_-__-__-%';
+-------+----------------------------------------------------------------------------------+---------------------+
| id    | name                                                                             | time                |
+-------+----------------------------------------------------------------------------------+---------------------+
| 74555 | review-ietf-6lo-privacy-considerations-04-secdir-lc-kaduk-2016-11-30-2           | 2016-11-30 18:48:03 |
| 74556 | review-ietf-6lo-privacy-considerations-04-secdir-lc-kaduk-2016-11-30-3           | 2016-11-30 18:50:59 |
| 71071 | review-ietf-alto-protocol-25-genart-lc-thomson-2014-01-26-2                      | 2014-01-26 22:12:13 |
| 70619 | review-ietf-appsawg-json-patch-08-genart-lc-even-2012-12-16-2                    | 2012-12-16 08:34:55 |
| 92785 | review-ietf-cbor-array-tags-07-opsdir-lc-dunbar-2019-08-26-2                     | 2019-08-26 14:13:29 |
| 94691 | review-ietf-dprive-rfc7626-bis-03-genart-lc-shirazipour-2019-12-04-2             | 2019-12-04 13:40:30 |
| 94692 | review-ietf-dprive-rfc7626-bis-03-genart-lc-shirazipour-2019-12-04-3             | 2019-12-04 13:40:32 |
| 71337 | review-ietf-eppext-reg-08-genart-lc-brim-2014-09-29-2                            | 2014-09-29 18:14:47 |
| 70323 | review-ietf-geopriv-policy-uri-genart-lc-black-2011-11-30-2                      | 2011-11-30 02:02:11 |
| 75601 | review-ietf-idr-bgp-prefix-sid-04-rtgdir-early-hopps-2017-03-07-4                | 2017-03-07 08:32:16 |
| 71989 | review-ietf-isis-node-admin-tag-08-genart-lc-yee-2016-04-30-2                    | 2016-04-30 08:57:33 |
| 70324 | review-ietf-l2vpn-arp-mediation-genart-telechat-mccann-2012-01-12-2              | 2012-01-12 22:16:38 |
| 71394 | review-ietf-mpls-mldp-in-band-wildcard-encoding-02-genart-lc-davies-2014-10-31-2 | 2014-10-31 20:47:32 |
| 90792 | review-ietf-netconf-subscribed-notifications-23-rtgdir-lc-singh-2019-04-16-2     | 2019-04-16 03:45:06 |
| 90743 | review-ietf-netconf-yang-push-22-genart-lc-bryant-2019-04-10-2                   | 2019-04-10 13:40:41 |
| 71861 | review-ietf-oauth-pop-architecture-07-genart-telechat-miller-2015-12-17-2        | 2015-12-17 17:34:56 |
| 70510 | review-ietf-ospf-prefix-hiding-genart-telechat-gurbani-2012-08-13-2              | 2012-08-13 15:59:56 |
| 94664 | review-ietf-stir-passport-divert-07-opsdir-lc-dunbar-2019-12-02-2                | 2019-12-02 14:59:57 |
| 71256 | review-ietf-straw-sip-traceroute-02-genart-lc-shirazipour-2014-07-10-2           | 2014-07-10 04:51:06 |
| 70336 | review-kompella-l2vpn-l2vpn-genart-telechat-even-2012-01-13-2                    | 2012-01-13 07:26:36 |
| 70689 | review-templin-intarea-seal-51-genart-lc-holmberg-2013-02-19-2                   | 2013-02-19 09:36:56 |
+-------+----------------------------------------------------------------------------------+---------------------+
mysql> select id,name,time from doc_document where name like 'review-%-2020-__-__-%';
+-------+--------------------------------------------------------------------+---------------------+
| id    | name                                                               | time                |
+-------+--------------------------------------------------------------------+---------------------+
| 96524 | review-ietf-capport-api-07-opsdir-lc-dunbar-2020-05-09-2           | 2020-05-09 15:06:44 |
| 96585 | review-ietf-capport-architecture-08-genart-lc-halpern-2020-05-16-2 | 2020-05-16 15:35:55 |
+-------+--------------------------------------------------------------------+---------------------+
21 rows in set (0.02 sec)

---

Issue migrated from trac:3007 at 2022-03-04 07:53:10 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com edited the issue description

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to accepted

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in release 17.7.1 (see the head of the branch touched by 863582e56a58c917f8e8fa19fa34095158708560)

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from accepted to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from ` tofixed`