Forms for managing review assignments might not pay enough attention to underlying state changes

type_defect | by rjsparks@nostrum.com

A recent sequence of with a review request and assignment let to a surprising result for the team secretary.

In 3598137fef9a41f40f0b5b6fa31667d73b2307ca: for h in req.history.all():
    ...:     print (h)
    ...:
Last Call review on draft-ietf-cellar-ffv1 by General Area Review Team (Gen-ART) Withdrawn as of 2020-07-03 12:01:50.556635
Last Call review on draft-ietf-cellar-ffv1 by General Area Review Team (Gen-ART) Requested as of 2020-07-03 11:38:27.923916
Last Call review on draft-ietf-cellar-ffv1 by General Area Review Team (Gen-ART) Assigned as of 2020-07-02 16:38:13.244023

In dc22fb842160a0c0387457a61838e807e01c8c4a: for h in asgn.history.all():
    ...:     print (h)
    ...:
Assignment for Gyan Mishra (Rejected) : genart Last Call of draft-ietf-cellar-ffv1 as of 2020-07-03 11:38:27.632392
Assignment for Gyan Mishra (Assigned) : genart Last Call of draft-ietf-cellar-ffv1 as of 2020-07-02 16:38:13.253112

The issue is likely that Jean still had the review assignment form open in her browser as rendered before Gyan rejected the request. The buttons on the form then became nonsensical, and if a POST was done, it should have failed.

There are no buttons to assign an additional reviewer on the assignment page. Jean would have had to go back to the team's overview page and select the request from the "Unassigned requests" list to make that assignment.

Further, the UI could provide some better hints. Buttons that say "withdraw" should probably be explicit and say "Withdraw request" or "withdraw assignment".

Or, maybe we should change the button to say "unassign"?

Issue migrated from trac:3015 at 2022-03-04 07:53:55 +0000

ietf-tools / datatracker

Forms for managing review assignments might not pay enough attention to underlying state changes #3015