search

ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
603 stars 367 forks source link

Notifications for "External resource change requested for draft-*" mesages in Datatracker #3285

Closed ietf-svn-bot closed 1 year ago

ietf-svn-bot commented 3 years ago

type_defect | by cmorgan@amsl.com

Hi! The Secretariat received the following ticket from Lars Eggert, but this looks like something more for the Tools Team. (I can't immediately tell what DKG did to trigger the mail this is about, but the fact that it's from ietf-secretariat-reply@ietf.org makes me think it's some sort of automatic Datatracker notification.)

--

From: lars@eggert.org

To: ietf-secretariat-reply@ietf.org

CC: iesg@ietf.org

Subject: Re: External resource change requested for draft-ietf-lamps-samples

Re: External resource change requested for draft-ietf-lamps-samples Hi,

I think it is sufficient if the ADs in question are CC’ed on these notifications, and not the entire IESG.

Lars

-- Sent from a mobile device; please excuse typos.

On May 19, 2021, at 00:34, IETF Secretariat ietf-secretariat-reply@ietf.org wrote:

 Daniel Kahn Gillmor dkg@fifthhorseman.net has requested changes to the additional resources for draft-ietf-lamps-samples:

Currently, this document has no additional resources.

It is requested that the additional resources be changed to:

tracker https://gitlab.com/dkg/lamps-samples/-/issues repo https://gitlab.com/dkg/lamps-samples.git

If this is an acceptable change, please visit

https://datatracker.ietf.org/doc/draft-ietf-lamps-samples/

and edit the additional resources accordingly.

Issue migrated from trac:3285 at 2022-03-04 08:40:45 +0000

ietf-svn-bot commented 3 years ago

@rjsparks@nostrum.com changed priority from n/a to minor

ietf-svn-bot commented 3 years ago

@rjsparks@nostrum.com changed status from new to accepted

ietf-svn-bot commented 3 years ago

@rjsparks@nostrum.com commented

Right now https://datatracker.ietf.org/mailtrigger/name/doc_external_resource_change_requested/ includes stream managers, which is where the IESG is coming in.

It's interesting that it also includes doc_ad, and the document does not yet have one? Perhaps doc_group_ads would be better.

We can consider adding logic to only include the stream manager if some other stream officers haven't already been included.

ietf-svn-bot commented 3 years ago

@lars@eggert.org commented

The IESG has gotten several more over the last few days:

I haven't received a single one of those before 2021-5-15, and four since. I wonder if a change was made to the datatracker around that time that caused these emails to (also) go to the IESG?

ietf-svn-bot commented 3 years ago

@lars@eggert.org commented

I wonder if these are caused by b08110b8381794b521b0f79ba5e57db5fc82d290.

ietf-svn-bot commented 3 years ago

@rjsparks@nostrum.com commented

Yes, and I've already described the needed change above - the mailtrigger being used currently always includes the stream_manager, which for the IETF stream is the IESG. We will have to rework the logic for that trigger to be smarter about the IETF stream and only include the iesg if there's not an AD that's already been included.

larseggert commented 2 years ago

Could we come back to this one? If I were to make the change, is it enough to edit ietf/name/fixtures/names.json or would I need to touch something else?

rjsparks commented 2 years ago

ietf/name/fixtures/names.json is only used for the tests - changing it will not affect production in any way.

The change that you are looking at would be adding code to https://github.com/ietf-tools/datatracker/blob/main/ietf/mailtrigger/models.py#L48 creating a new type of recipient and change the database (ask the secretariat to do it through the admin, or add a migration) to change the set of recipients at https://datatracker.ietf.org/mailtrigger/name/doc_external_resource_change_requested/.

The new code would replace doc_stream_manager with something that was smarter - returning a specific ad or pair of ads if the stream was IESG, and the stream manager otherwise.

larseggert commented 1 year ago

I think this is beyond my datatracker-fu, but I would still like this to be fixed. The IESG does not need these emails.

rjsparks commented 1 year ago

I changed the relevant mailtrigger from image to image

(that is, I removed the doc_stream_manager recipient and added the doc_non_ietf_stream_manager recipient.)

That there is a stream manager based recipient in the trigger at all is a fallback (to find someone to approve the request), and for the ietf stream, the other recipients cover that well enough already.

I think this change resolves the issue, so I'm closing it. Let me know if you think it needs further tuning instead.