search

ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
588 stars 358 forks source link

AD ballot position links not working #3351

Closed ietf-svn-bot closed 3 years ago

ietf-svn-bot commented 3 years ago

owner:jennifer@painless-security.com resolution_fixed type_defect | by lars@eggert.org

The per-AD ballot position links in the various ballot popups on https://datatracker.ietf.org/iesg/agenda/ are (often) not working, because they are (often) not unique on the page. The anchor needs to be prefixed with the docname, and the link needs to use that.

Issue migrated from trac:3351 at 2022-03-04 09:08:14 +0000

ietf-svn-bot commented 3 years ago

@rjsparks@nostrum.com changed priority from n/a to medium

ietf-svn-bot commented 3 years ago

@rjsparks@nostrum.com changed status from new to accepted

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com changed status from accepted to assigned

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com set owner to jennifer@painless-security.com

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com commented

It looks to me like this only happens after opening at least two of the pop-ups without refreshing the browser page. Is that compatible with your "often" experience?

ietf-svn-bot commented 3 years ago

@lars@eggert.org commented

That sounds right. The bug is probably that the modal doesn't get removed from the DOM after it is closed. (This is probably even code I wrote originally, oops.)

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com commented

Ok. I have a patch that adds the doc name as a prefix, which fixes the problem. I'm planning to leave the modals in the DOM - I think the agenda would become overwhelming to the user before there are enough modals that the HTML bogs down the browser.

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com changed status from assigned to closed

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com set resolution to fixed

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com commented

Fixed in 54a524b124e7d9f508dc9433878f44293de5d025:

Include doc name in ballot popup anchors. Fixes #3351. Commit ready for merge.

ietf-svn-bot commented 3 years ago

@rjsparks@nostrum.com commented

Fixed in 6cdd1c58ae324f31272ba59dadf87a7505c74036:

Merged in 54a524b124e7d9f508dc9433878f44293de5d025 from jennifer@painless-security.com: Include doc name in ballot popup anchors. Fixes #3351.