search

ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
608 stars 373 forks source link

Reconsider allowing reviewers to provide arbitrary URLs when completing a review #3586

Open rjsparks opened 2 years ago

rjsparks commented 2 years ago

Is the ability to point to an arbitrary place still needed, or is it sufficient to restrict the place to find already published reviews to mailarchive.ietf.org?

larseggert commented 2 years ago

Reviews should be contributions to the IETF, so they need to be submitted in a way that makes them such (e.g., email). I don't think giving us a URL is sufficient without the material there including the IETF copyright blurb.

rjsparks commented 2 years ago

The original driver for providing a URL was for team secretaries or reviewers to capture a review sent directly to a reveiw-team (or working group) mailing list by reviewers that were not yet consistently using the datatracker to enter reviews (I think secdir may still have some reviewers that @kivinen finalizes reviews for). Those reviews have gone through a channel that already makes them an official contribution. Given that all the review team lists are hosted at IETF and have archives in mailarchive.ietf.org, perhaps the thing to do is only allow URLs into that archive?

larseggert commented 2 years ago

That makes sense. But how many times are people really using that URL functionality; do you have data?

kivinen commented 2 years ago

Robert Sparks writes:

The original driver for providing a URL was for team secretaries or reviewers to capture a review sent directly to a reveiw-team (or working group) mailing list by reviewers that were not yet consistently using the datatracker to enter reviews (I think secdir may still have some reviewers that @kivinen finalizes reviews for). Those reviews have gone through a channel that already makes them an official contribution. Given that all the review team lists are hosted at IETF and have archives in mailarchive.ietf.org, perhaps the thing to do is only allow URLs into that archive?

Yes, there are still some people in secdir who do send emails directly to the secdir list, and do not use datatracker to close their reviews, and I do fill the data in for them. I always do use the mailarchive urls when filling in the data, i.e., use the automatic search from the mailing list provided by the datatracker, but there has been cases where that does not work, and I have to enter the url manually.

Reasons for the automatic search not working is usually that reviewer spelled the name of the draft incorrectly on the subject, thus automatic search does not find it. -- @.***