ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
620 stars 389 forks source link

New agenda page is no longer showing query parameters #5219

Open larseggert opened 1 year ago

larseggert commented 1 year ago

Describe the issue

The new agenda page seems to hide the agenda filtering query parameters. This breaks my workflow.

I append my query parameter string from the last meeting to the agenda URL for the upcoming meeting, then look at the results, add/drop sessions as needed, and then copy/paste the new query string into my calendar subscription.

This is now no longer possible?

Code of Conduct

NGPixel commented 1 year ago

You can get the URL with all the filters by clicking the "Share" button in the top right corner of the agenda page.

larseggert commented 1 year ago

Ah! But it isn't quite doing what it should be doing.

For example, I select the "gen" area. With the old page, that resulted in something like ?filters=gen, i.e., I could use the same URL for future meetings (just changing the meeting number) and it would match whatever GEN-area WGs and BOFs happened at the time.

The new page results in ?filters=gendispatch,emodir,hackathon,hotrfc,systers,tools, i.e., it expands all the groups. That means I can't use that URL for future meetings.

(Also, the "gen" button should only select GEN-area WGs and BOFs, and not also meetings of teams such as emodir,hackathon,hotrfc,systers,tools...)

larseggert commented 1 year ago

There also doesn't seem to be a way in the GUI anymore to include all BOFs?

NGPixel commented 1 year ago

@larseggert This is set by the secretariat. For example, the 115 agenda has it: https://datatracker.ietf.org/meeting/115/agenda

larseggert commented 1 year ago

What do you mean by "this"?

NGPixel commented 1 year ago

The list of available filters / areas in the agenda. The 115 agenda has a BOF filter available. The secretariat would need to define a similar one for 116 for it to appear in the list.

larseggert commented 1 year ago

Ah, it is there, just not at all in the spot I was expecting it. Can we move that up nearer to the WGs rather than burying it down at the bottom with all the things that don't matter for most?

larseggert commented 1 year ago

But my main issue remains that I can't use the ical URLs generated anymore. I don't really use the agenda page, because I have way too many other overlapping meetings - I just use the ics functionality to get things into my calendar app.

rjsparks commented 1 year ago

We had another issue that I'm not putting my hands on quickly that called out that the URLs for the ics download or subscribe are unobtainable. In that discussion we decided that the URLs would be added to the "Share" tab, and make it so that you can right click the buttons and get addresses.

The second part is already done - once you've saved your selections, you can go to the Add to you calendar, then right-click whether you want the single-snapshot ics or the calendar subscription and copy the link.

In a pinch, you can edit one to be the other. From

https://datatracker.ietf.org/meeting/116/agenda?filters=dispatch,stir,moq,gendispatch,saag,secdispatch,iabopen,code-sprint,ietf-plenary,welcome-reception-meeting-host-demonstrations,wg-chairs-forum-for-wg-chairs-only,ietf-116-social-event-at-osanbashi-pier-hosted-by-wide,rswg,bpf

you can derive

webcal://datatracker.ietf.org/meeting/116/agenda.ics?show=dispatch,stir,moq,gendispatch,saag,secdispatch,iabopen,code-sprint,ietf-plenary,welcome-reception-meeting-host-demonstrations,wg-chairs-forum-for-wg-chairs-only,ietf-116-social-event-at-osanbashi-pier-hosted-by-wide,rswg,bpf

We should make it so that the parameter name "show" vs "filters" does not vary.

And we should make it so that the links can just be taken from the Share tab.

Nick - if you find that issue quicker than me, point to it here. If I'm wrong and it hasn't made it to github yet, please add it.

rjsparks commented 1 year ago

Can we move that up nearer to the WGs rather than burying it down at the bottom with all the things that don't matter for most?

That whole bottom row is slowly evolving away. Lets talk about the Bof button at the codesprint.

larseggert commented 1 year ago

More is needed - see my comment starting with "Ah!"

jennifer-richards commented 1 year ago

We should make it so that the parameter name "show" vs "filters" does not vary.

There's a bit more of a difference between these than just the parameter name. The webcal ics page still uses the keyword syntax that the old agenda page used. That used both show and hide parameters. The purpose of that was to allow selection of things like "All of ART except avtcore" via ?show=art&hide=avtcore.

I think the new agenda page simply turns "ART" into a list of individual group keywords. Selecting ART and deselecting "avtcore" turns into ?filters=cbor,cdni,core,....

I'm not sure whether that is better, worse, or just different. It will certainly behave differently when trying to reuse a URL for a new meeting by editing the meeting number unless the two meetings have the same groups in the area.

The BoF button seems to be different again - selecting it both adds "bof" and the individual BoF group keywords to the filters list. Deselecting individual sessions removes the individual keywords but leaves bof. The display still displays all the sessions, even if they're not selected. I believe this will be the same between the agenda and the webcal pages, but I'd have expected this to give ?show=bof&hide=dbound2 in the old UI.

Definitely need to discuss what the "correct" behavio(u)r is here.

rjsparks commented 1 year ago

I'm not sure whether that is better, worse, or just different.

It is worse, and Lars calls out the use case showing why it's worse. An ART AD expects to be able to subscribe to art, and cut paste URLs from last meeting to apply to the next meeting without having to see if the constituency of the art area changed.

larseggert commented 1 year ago

What Robert said. And it applies to BOFs and other meeting types, too.

jennifer-richards commented 1 year ago

Ok. There was some JS code for the old agenda page that dealt with simplifying expressions when more than one keyword applied to a session. That might be worth looking at because I recall it was a little bit annoying to make something sensible happen