search

ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
568 stars 343 forks source link

review reject failure #5470

Open cindymorgan opened 1 year ago

cindymorgan commented 1 year ago

Describe the issue

Via Michael Richardson:

Subject: review reject failure From: "Michael Richardson" mcr+ietf@sandelman.ca Date: Wed, 05 Apr 2023 19:21:35 -0400

I just rejected an (IoTDIR) review request, and was directed to:

https://datatracker.ietf.org/doc/draft-nichols-iotops-defined-trust-transport/reviewrequest/14380/rejectreviewerassignment/

The page you were looking for couldn't be found The requested URL was not found on this server. If you entered the URL manually please check your spelling and try again.

Code of Conduct

jennifer-richards commented 2 months ago

This has come up again. It occurs if a user submits a rejection more than once. The first request succeeds and subsequent requests fail with a 404 because the review assignment is not in the appropriate state to be rejected.

https://github.com/ietf-tools/datatracker/blob/08e953995a04f8940c75b9bfc2cfad71ee15faee/ietf/doc/views_review.py#L382-L384

Instead of a 404, attempting to reject a review assignment that has already been rejected should return a page indicating as much. While at it, think about whether there are other review assignment states that can't be rejected but might also warrant returning an informational page.