search

ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
624 stars 392 forks source link

United Kingdom is no longer in the EU #7236

Open bkmgit opened 8 months ago

bkmgit commented 8 months ago

Describe the issue

When viewing meeting statistics by country, the United Kingdom is included in the EU total https://datatracker.ietf.org/stats/meeting/119/country/ but the United Kingdom is no longer in the EU. Either the wording should be changed or the United Kingdom totals should not be included.

Code of Conduct

rjsparks commented 8 months ago

The stats module is slated for deletion. This observation will be accounted for with the re-implementation of the module.

kesara commented 8 months ago

Stats are per continent. So it's correct to include United Kingdom in Europe.

bkmgit commented 8 months ago

@kesara The incorrect section is EU (European Union) is not a country, but has been added for reference, as the sum of all current EU member countries: Austria, Belgium, Bulgaria, Croatia, Cyprus, Czech Republic, Denmark, Estonia, Finland, France, Germany, Greece, Hungary, Ireland, Italy, Latvia, Lithuania, Luxembourg, Malta, Netherlands, Poland, Portugal, Romania, Slovakia, Slovenia, Spain, Sweden, United Kingdom .

It can be found in https://github.com/ietf-tools/datatracker/blob/main/ietf/templates/stats/document_stats_author_country.html#L75 and https://github.com/ietf-tools/datatracker/blob/main/ietf/templates/stats/meeting_stats_country.html#L91 but if it will be deleted, that is fine. Grouping by trade regions maybe helpful, though the country counts are sufficient and allow one to aggregate if they want.

kesara commented 8 months ago

@bkmgit thanks for clarifying. You are correct. I was looking at the wrong data view.