ietf-tools / datatracker

The day-to-day front-end to the IETF database for people who work on IETF standards.
https://datatracker.ietf.org
BSD 3-Clause "New" or "Revised" License
588 stars 350 forks source link

Unable to save TSVART review assignments #7842

Open gloinul opened 1 month ago

gloinul commented 1 month ago

Describe the issue

Was going through unassigned review requests for TSVART. https://datatracker.ietf.org/group/tsvart/reviews/manage/unassigned/

After having given one doc to a reviewer and closing the rest I am unable to save. In fact none of the bottom buttons (Save Changes, Save and Continue, and Refresh) appear to be working. I have tried this both in Safari Version 17.6 (19618.3.11.11.5) and Chrome Version 127.0.6533.120 (Official Build) (arm64) getting the same result. I am logged in on both. I have also tried on another computer in Firefox 129.0.1 without success.

Code of Conduct

rjsparks commented 1 month ago

Duplicate of #7839.

@gloinul Please check something for me. Look for that "Review Type" field and ensure it's set to telechat review. If setting that doesn't clear the issue, let me know and we'll get Éric to put in an explicit review request for tsvart.

gloinul commented 1 month ago

I don't have the same view or that field indicating a need to select that is shown in #7839 as I attempt to close the request. If I select to assign it I do get the drop down to select review type.

Screenshot 2024-08-20 at 17 07 25

I do note that that rfc81110-to-ieee do have both telechat and Last call dead line.

So do you want me to work around this by assigning it to myself and then cancel the review?

rjsparks commented 1 month ago

No - I'll get Éric to explicitly request a review as a workaround - you can then say "will not review" without it breaking. Thanks for the screenshot - it gives insight into a part of the workflow that is breaking that wasn't obvious before.

gloinul commented 1 month ago

Thanks it worked now, (using refresh button on page), and then I could save with the intended choices for all the documents.

rjsparks commented 1 month ago

Keeping this issue open as it highlights a place that the form needs to be corrected.

evyncke commented 1 month ago

Do I still need to request a TSVART review ? It seems that Magnus' issue is solved now.

gloinul commented 1 month ago

@evyncke no, you don't need to for me. I wasn't going to assign draft-wkumari-rfc81110-to-ieeee to any reviewer.