ietf-tools / mailarchive

IETF Mail List Archives
https://mailarchive.ietf.org
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Dev setup: dev container db port (3306) #3737

Closed microamp closed 5 months ago

microamp commented 5 months ago

There are two files named docker-compose.extend.yml.

find . -type f -name "docker-compose.extend.yml"
./docker/docker-compose.extend.yml
./.devcontainer/docker-compose.extend.yml

One difference is the database port number, 5432 vs 3306.

diff -C 2 -w ./docker/docker-compose.extend.yml ./.devcontainer/docker-compose.extend.yml
*** 11,15 ****
      db:
          ports:
!             - '5432'
      es:
          ports:
--- 11,15 ----
      db:
          ports:
!             - '3306'
      es:
          ports:

The latter is being used in ./.devcontainer/devcontainer.json.

grep -r "docker-compose.extend.yml" ./.devcontainer
.devcontainer/devcontainer.json:        "dockerComposeFile": ["../compose-dev.yml", "docker-compose.extend.yml"],

While this doesn't cause tests to fail locally, 5432 should be the correct one to use (Postgres)?