search

ietf-tools / mailarchive

IETF Mail List Archives
https://mailarchive.ietf.org
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

feat: add nginx container to serve robots.txt #3836

Closed rpcross closed 2 weeks ago

rpcross commented 3 weeks ago

I based this on Datatracker nginx setup. Does this look good for mail archive? I am not familiar with the $${keepempty} usage in nginx conf.

jennifer-richards commented 3 weeks ago

I am not familiar with the $${keepempty} usage in nginx conf.

This is a convention we're using to get around quoting issues. The issue is that kustomize does not support environment variable substitution, so we run its output through envsubst to do that for us. That will strip out any strings like $whatever, and the nginx conf needs those. The $${keepempty}whatever reduces down to $whatever in this process. The "keepempty" could be any string that's not an actual environment variable.

This may go away as we refactor how we deal with config / secrets in k8s as we might not need the envsubst step any more.