search

ietf-tools / semver-action

GitHub Action to calculate the next release version based on conventional commits
BSD 3-Clause "New" or "Revised" License
56 stars 22 forks source link

Request: "patch" option for noVersionBumpBehavior #33

Closed houserx-jmcc closed 1 year ago

houserx-jmcc commented 1 year ago

This may be an edge case, but there are some situations where we want to force a version increment even when no matching commits found. For example, we have only one commit being tracked and there is a typo in it, so it does not resolve to a version bump.

We still would release the commit in this case, so an option to default to a patch version bump when "noVersionBumpBehavior" is true would be really handy for edge cases.

NGPixel commented 1 year ago

If you only have 1 commit, wouldn't it make more sense to fix the commit message instead?

You can also set patchAll to true for the same behavior...

houserx-jmcc commented 1 year ago

If you only have 1 commit, wouldn't it make more sense to fix the commit message instead?

Well, that is a simple hypothetical example :) I can go into more details if you'd like, but the request is still to have a backstop default of "patch" as an option.

You can also set patchAll to true for the same behavior...

Per my reading of the docs, doesn't this then not allow minor or major versions?

NGPixel commented 1 year ago

No, it means that anything that is not major or minor will be counted as patch.

houserx-jmcc commented 1 year ago

Ah! That is perfect then. I misunderstood it, thanks for clarifying!