Restore ability to use STDIN

ietf-tools / svgcheck

Check SVG against RFC schema

BSD 3-Clause "New" or "Revised" License

15 stars 13 forks source link

Restore ability to use STDIN #36

Open kesara opened 1 year ago

kesara commented 1 year ago

Restore ability to use standard input for svgcheck. This functionality was unintentionally removed in #28.

larseggert commented 1 year ago

We need a test suite :-)

kesara commented 1 year ago

We need a test suite :-)

I assume that you are talking about a test suite that covers all popular tools used by the community.

rjsparks commented 1 year ago

I really hope the path to redefining what svg is acceptable is opening. It would be a much better investment to build a more maintainable checker against those rules than continuing to build infrastructure around a set of rules we know we're going to leave. (And to be explicit, I would expect to write something new for those rules rather than adjust this current implementation).

hoehrmann commented 2 months ago

The problem is this line https://github.com/ietf-tools/svgcheck/blob/40c2914c688de757b9e72560920dfd890ff0f8f9/svgcheck/run.py#L110 - it looks for a "stdin" file in the current working directory instead of reading from the moral equivalent of /dev/stdin.

(Via https://github.com/cabo/kramdown-rfc/issues/233)