ietf-tools / www

A customized CMS for the IETF website
BSD 3-Clause "New" or "Revised" License
25 stars 44 forks source link

fix: Make sure `BlogPageAuthor.author` is not null #346

Closed mgax closed 10 months ago

mgax commented 10 months ago

Fixes https://github.com/ietf-tools/wagtail_website/issues/238

There are currently no NULL values for BlogPageAuthor.author in the database. I've made the author field required, as there seems to be no point in having an author entry with no author.

rjsparks commented 10 months ago

@ghwood - Do we have a requirement to be able to post an authorless blog article?

mgax commented 10 months ago

Do we have a requirement to be able to post an authorless blog article?

To be clear, it's still possible to have no authors attached to the blog post. This change only means that, when adding an author relationship, it must point to an actual author (i.e. the author field of the relationship may not be NULL).

ghwood commented 10 months ago

We need to be able to have posts that appear like this: https://www.ietf.org/blog/chairs-training-2023/ where no authors are specified :

image
rjsparks commented 10 months ago

Right - and Alex confirms that's possible.