ietf-tools / www

A customized CMS for the IETF website
BSD 3-Clause "New" or "Revised" License
22 stars 45 forks source link

fix: Generate local URLs for megamenu and skip empty links #376

Closed mgax closed 6 months ago

mgax commented 6 months ago

Refs. https://github.com/ietf-tools/wagtail_website/issues/326

I was testing what happens when a page from the megamenu is deleted, something I'd skipped over in the main PR, and found a couple of related issues.

With this change, if a page is deleted, its link becomes empty, and it will be skipped when rendering the menu.

This PR also makes local development slightly easier: in the megamenu, links to pages will be generated as local URLs, so that they point to localhost instead of www.ietf.org.

Additionally, after applying the utils.0009_megamenu migration, I suggest running ./manage.py rebuild_references_index. This way, when deleting a page that is part of the megamenu, the CMS will include the MainMenuItem object in its list of references. (References are normally kept up to date, but when creating content through migrations, the relevant hook doesn't get called.)