search

ietf-tools / www

A customized CMS for the IETF website
BSD 3-Clause "New" or "Revised" License
22 stars 45 forks source link

fix: Use Nginx's port as container port in Helm chart #428

Closed microamp closed 2 months ago

microamp commented 2 months ago

Fixes #425

Datatracker was used as a reference during the initial build of the Helm chart, but there are some differences in port numbers being used.

Nginx Gunicorn
datatracker 8000 8001
www 80 8000

The Helm chart has been updated accordingly.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.72%. Comparing base (c80251d) to head (dfb7484).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #428 +/- ## ======================================= Coverage 82.72% 82.72% ======================================= Files 124 124 Lines 2599 2599 ======================================= Hits 2150 2150 Misses 449 449 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kesara commented 2 months ago

Not sure this is going to work with https://github.com/ietf-tools/www/blob/main/docker/gunicorn.py#L10 www docker image is still configured to run on port 8000?

There's an nginx proxy in front of gunicorn, so this is not an issue.

microamp commented 2 months ago

There's an nginx proxy in front of gunicorn, so this is not an issue.

Yes, there's Nginx in front. https://github.com/microamp/www/blob/chore/k8s-probes/docker/nginx-sandbox.conf#L7