search

ietf-tools / www

A customized CMS for the IETF website
BSD 3-Clause "New" or "Revised" License
22 stars 45 forks source link

build: Run collectstatic command #464

Closed kesara closed 3 weeks ago

kesara commented 3 weeks ago

Fixes #463

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.08%. Comparing base (ee2a89c) to head (c62b412).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #464 +/- ## ======================================= Coverage 96.08% 96.08% ======================================= Files 153 153 Lines 3293 3293 ======================================= Hits 3164 3164 Misses 129 129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

microamp commented 3 weeks ago

We now run collectstatic when we build a new image. See https://github.com/ietf-tools/www/pull/427 for more info.

Is there a need to run it dynamically?

kesara commented 3 weeks ago

We now run collectstatic when we build a new image. See #427 for more info.

Is there a need to run it dynamically?

Not running it dynamically if the static directory is mounted directory causes issues. This is especially required when running on a read-only filesystem where only select directories are mounted as writable. There's no harm in running this again if the directory is writable.

kesara commented 3 weeks ago

@microamp I'm closing this, with the caveat that /static doesn't need to be updated from time to time. If it does, DO implementation will need to mount a writable directory for /static and run this command in init.sh.