Closed kitterma closed 1 year ago
I can, but it's not needed. Any version will work fine. The API hasn't changed.
On June 18, 2023 10:40:28 AM UTC, Kesara Rathnayake @.***> wrote:
@kesara commented on this pull request.
@@ -1,4 +1,4 @@ -appdirs>=1.4.4 +platformdirs
Can you add the latest version
platformdirs>=3.6.0
?
I can, but it's not needed. Any version will work fine. The API hasn't changed. … On June 18, 2023 10:40:28 AM UTC, Kesara Rathnayake @.***> wrote: @kesara commented on this pull request. > @@ -1,4 +1,4 @@ -appdirs>=1.4.4 +platformdirs Can you add the latest version
platformdirs>=3.6.0
?
@kitterma, to follow the current standard in our requirements.txt
file, I'd like to add the latest working version.
You can make an extra commit to add the change or edit the PR and allow edits from maintainers.
Also, allow edits by maintainers is checked, so feel free to do any other cleanups needed if you'd rather.
Also, allow edits by maintainers is checked, so feel free to do any other cleanups needed if you'd rather.
Awesome! Thanks for the PR.
Platformdirs is API compatible with appdirs, all that needs to be changed is the module name. It is a friendly fork of appdirs that was created after appdirs went unmaintained in 2020.
I've tried this out at tests all still pass. I think it's a straightforward change and it's better to use something that's got active maintainers.