ietf-tools / xml2rfc

Generate RFCs and IETF drafts from document source in XML according to the IETF xml2rfc v2 and v3 vocabularies
https://ietf-tools.github.io/xml2rfc/
BSD 3-Clause "New" or "Revised" License
65 stars 38 forks source link

fix: Switch from appdirs to platformdirs, since it is maintained #1009

Closed kitterma closed 1 year ago

kitterma commented 1 year ago

Platformdirs is API compatible with appdirs, all that needs to be changed is the module name. It is a friendly fork of appdirs that was created after appdirs went unmaintained in 2020.

I've tried this out at tests all still pass. I think it's a straightforward change and it's better to use something that's got active maintainers.

kitterma commented 1 year ago

I can, but it's not needed. Any version will work fine. The API hasn't changed.

On June 18, 2023 10:40:28 AM UTC, Kesara Rathnayake @.***> wrote:

@kesara commented on this pull request.

@@ -1,4 +1,4 @@ -appdirs>=1.4.4 +platformdirs

Can you add the latest version platformdirs>=3.6.0?

kesara commented 1 year ago

I can, but it's not needed. Any version will work fine. The API hasn't changed. On June 18, 2023 10:40:28 AM UTC, Kesara Rathnayake @.***> wrote: @kesara commented on this pull request. > @@ -1,4 +1,4 @@ -appdirs>=1.4.4 +platformdirs Can you add the latest version platformdirs>=3.6.0?

@kitterma, to follow the current standard in our requirements.txt file, I'd like to add the latest working version. You can make an extra commit to add the change or edit the PR and allow edits from maintainers.

kitterma commented 1 year ago

Also, allow edits by maintainers is checked, so feel free to do any other cleanups needed if you'd rather.

kesara commented 1 year ago

Also, allow edits by maintainers is checked, so feel free to do any other cleanups needed if you'd rather.

Awesome! Thanks for the PR.