fix: Allow non-ASCII values in all attributes

ietf-tools / xml2rfc

Generate RFCs and IETF drafts from document source in XML according to the IETF xml2rfc v2 and v3 vocabularies

https://ietf-tools.github.io/xml2rfc/

BSD 3-Clause "New" or "Revised" License

63 stars 35 forks source link

fix: Allow non-ASCII values in all attributes #1106

Closed kesara closed 4 months ago

kesara commented 4 months ago

PR #1017 allowed Unicord characters everywhere. This fixes a bug that xml2rfc was guarding against non-ASCII characters in attribute values. With --warn-bare-unicode, xml2rfc will warn if non-ASCII characters are present in attribute values.

Fixes #1105

cabo commented 4 months ago

Thanks for the quick fix!

I'm not sure why you are taking out the latinscript tests for the ascii... attributes; I think these were useful.

kesara commented 4 months ago

@cabo My initial thoughts were they are not required any more because all Unicode characters are allowed. But since they are special ASCII attributes that allow Latin scripts, I guess it's worth keeping them. :) I'll make a change.

cabo commented 4 months ago

Looks good to me now.

The warning message uses "they" to refer to "non-ASCII content", maybe "it"?