search

ietf-tools / xml2rfc

Generate RFCs and IETF drafts from document source in XML according to the IETF xml2rfc v2 and v3 vocabularies
https://ietf-tools.github.io/xml2rfc/
BSD 3-Clause "New" or "Revised" License
63 stars 35 forks source link

Some tables within `<dd>` overlap text in pdf output #1117

Closed rvanrheenen closed 3 months ago

rvanrheenen commented 3 months ago

Describe the issue

Tables 3 and 6 overlap the text that precedes them in the pdf output (these tables looks fine in the txt and html).

These tables appear in <dd> within <dl>, but Tables 1-35 are tagged the same way and do not have this issue. Note that spacing="compact" is used for the <dl>.

The overlap does not occur if the <dl> is updated to include newline="true", but this changes the appearance of the entire list.

Files: https://www.rfc-editor.org/v3test/rfc9559-TEST.xml https://www.rfc-editor.org/v3test/rfc9559-TEST.txt https://www.rfc-editor.org/v3test/rfc9559-TEST.html https://www.rfc-editor.org/v3test/rfc9559-TEST.pdf

Code of Conduct

ajeanmahoney commented 3 months ago

See also https://github.com/ietf-tools/xml2rfc/issues/1086

rvanrheenen commented 3 months ago

Also see #1118 and #1086 (other issues re <table> in <dl> found in same document)

kesara commented 3 months ago

Duplicate of #1086

rvanrheenen commented 3 months ago

@kesara I'd like to clarify that this issue is different from #1086.

This issue affects only Tables 3 and 6 of the pdf output. They cover part of the text preceding them so you can't see it. This doesn't occur in other tables in the doc that are tagged the same way, and this does not occur in the txt or html outputs.

1086 also deals with spacing, but not this particular thing.

kesara commented 3 months ago

@rvanrheenen I thought #1086 covers the same issue but also requests more. Also Table 6 in the example has the same issue. Reopening this as this is a more targeted bug report.

rvanrheenen commented 3 months ago

@kesara thank you! Yes, I examined each table in the test files, and only Table 3 and Table 6 have this issue. Thank you!

ajeanmahoney commented 3 months ago

@kesara, the RPC will work on how we want the inclusion of a table within a definition list to look for all list formats (true/false newline, normal/compact spacing) and will open a new issue, thanks!