search

ietf-tools / xml2rfc

Generate RFCs and IETF drafts from document source in XML according to the IETF xml2rfc v2 and v3 vocabularies
https://ietf-tools.github.io/xml2rfc/
BSD 3-Clause "New" or "Revised" License
69 stars 38 forks source link

HTAB in artwork/sourcecode is accepted #403

Closed ietf-svn-bot closed 3 years ago

ietf-svn-bot commented 5 years ago

owner:mrcullen42@gmail.com resolution_fixed type_defect | by julian.reschke@gmx.de

...but shouldn't, see https://greenbytes.de/tech/webdav/rfc7991.html#elements.

An example source file happens to be https://trac.tools.ietf.org/tools/xml2rfc/trac/browser/trunk/cli/tests/input/elements.xml?rev=3042

Issue migrated from trac:403 at 2022-02-05 12:48:24 +0000

ietf-svn-bot commented 5 years ago

@julian.reschke@gmx.de commented

The example file (elements.xml) apparently was fixed in https://trac.tools.ietf.org/tools/xml2rfc/trac/changeset/3236/trunk/cli/tests/input/elements.xml.

I haven't checked whether xml2rfc now also rejects TABs in sourcecode.

ietf-svn-bot commented 5 years ago

@julian.reschke@gmx.de changed _comment0 which not transferred by tractive

ietf-svn-bot commented 5 years ago

@julian.reschke@gmx.de commented

The AUTH48 XML for RFC 8662 has an HTAB in artwork, so apparently the problem is not solved yet. The output files do not seem to contain it, but the processor definitively should generate a warning or an error.

ietf-svn-bot commented 4 years ago

@julian.reschke@gmx.de changed priority from medium to major

ietf-svn-bot commented 4 years ago

@julian.reschke@gmx.de commented

I just checked with 2.36.0 and apparently TABs are accepted and converted to multiple SP characters.

Raised priority to "major".

ietf-svn-bot commented 4 years ago

@henrik@levkowetz.com changed priority from major to minor

ietf-svn-bot commented 4 years ago

@henrik@levkowetz.com _changed component from Version_3_cli_txt to v3 vocabulary, v2 xml2rfc_

ietf-svn-bot commented 4 years ago

@henrik@levkowetz.com changed status from new to accepted

ietf-svn-bot commented 4 years ago

@henrik@levkowetz.com commented

To do: Add warning or note when changing tabs to spaces in and .

ietf-svn-bot commented 3 years ago

@mrcullen42@gmail.com commented

Testing shows that there is already a warning for a tab character in : "Warning: Found tab on line 2 of ". I will add a similar warning when a tab is found in .

ietf-svn-bot commented 3 years ago

@mrcullen42@gmail.com changed status from accepted to assigned

ietf-svn-bot commented 3 years ago

@mrcullen42@gmail.com changed owner from ` tomrcullen42@gmail.com`

ietf-svn-bot commented 3 years ago

@julian.reschke@gmx.de commented

"Tab characters (U+0009) inside of this element are prohibited."

So I think this needs to be more than a warning.

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com changed status from assigned to closed

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com changed resolution from ` tofixed`

ietf-svn-bot commented 3 years ago

@jennifer@painless-security.com commented

Fixed in 69863cb29c20151788ff9316debef5088f7b1b22:

Fix indentation error that prevented normalizing ascii-art whitespace. Fixes #403. Commit ready for merge.

ietf-svn-bot commented 3 years ago

@rjsparks@nostrum.com commented

Fixed in e138c90351b5c13cb32c2332427856050197f1af:

Merged in 69863cb29c20151788ff9316debef5088f7b1b22 from jennifer@painless-security.com:\n Fix indentation error that prevented normalizing ascii-art whitespace. Fixes #403.