fix: Include figure prefix in name before rendering text

ietf-tools / xml2rfc

Generate RFCs and IETF drafts from document source in XML according to the IETF xml2rfc v2 and v3 vocabularies

https://ietf-tools.github.io/xml2rfc/

BSD 3-Clause "New" or "Revised" License

64 stars 38 forks source link

fix: Include figure prefix in name before rendering text #966

Open kesara opened 1 year ago

kesara commented 1 year ago

Fixes #https://github.com/ietf-tools/xml2rfc/issues/961

cabo commented 1 year ago

Is the same fix needed for all the other uses of .tjoin()? If not, why not?

kesara commented 1 year ago

Is the same fix needed for all the other uses of .tjoin()? If not, why not?

tjoin() is used to render reference, references -> name, section -> name, table -> name. I'll experiment and see if this fix is adversely affecting any of those.

cabo commented 1 year ago

I'll experiment and see if this fix is adversely affecting any of those.

I just thought that they may have the same bug that Alice reported (line-breaking hyphens and putting them back together with a superfluous space), which would need to be fixed in a similar way.