search

ietf-wg-acme / acme

A protocol for automating certificate issuance
https://datatracker.ietf.org/doc/draft-ietf-acme-acme/
933 stars 190 forks source link

Include the 'index' link relation in all example server responses that return a resource #493

Closed robstradling closed 5 years ago

robstradling commented 5 years ago

Section 7.1 says: The "index" link relation is present on all resources other than the directory and indicates the URL of the directory.

This PR adds an example "index" link relation to the example server responses that return a resource but that didn't already have it.

I'm interpreting "is present on all resources" to not include responses that return a problem document. Is that right?

bifurcation commented 5 years ago

I agree with @cpu here -- an HTTP response reflects the status of a resource, even if that status is a problem

robstradling commented 5 years ago

OK. I've made that change.

robstradling commented 5 years ago

@cpu Yeah, I'd noticed that and I'd considered switching the order for consistency. But then I thought perhaps it was wrong to be unnecessarily consistent, because that might be taken as implying that the order of the HTTP response headers matters (which it doesn't). I have no strong feelings though, so I'll switch them.