ietf-wg-bpf / ebpf-docs

eBPF Standard Documentation
37 stars 5 forks source link

ISA: Comments from Ines Robles #144

Closed dthaler closed 1 month ago

dthaler commented 1 month ago

https://datatracker.ietf.org/doc/review-ietf-bpf-isa-02-genart-lc-robles-2024-05-16/

Summary:

This document specifies the BPF instruction set architecture (ISA). The document is clear and well-written. No major issues were found, just some minor suggestions.

Major issues: None Minor issues: None Nits/editorial comments:

Thanks for this document,

Ines

dthaler commented 1 month ago

Proposed patch adding captions posted at https://mailarchive.ietf.org/arch/msg/bpf/wu_vtrec-wZdQAqpSi_1P66iHlU/

dthaler commented 1 month ago

Patch was merged but indentation was off for two tables causing the caption to not render correctly. Proposed fix posted to https://mailarchive.ietf.org/arch/msg/bpf/P_AeRgHrfQ1RG7UpapDn6kKTaRg/

dthaler commented 1 month ago

Fixed in draft-03