search

ietf-wg-bpf / ebpf-docs

eBPF Standard Documentation
40 stars 5 forks source link

tools/ebpf-check: Fix missing comma in docs-to-ops.py #7

Closed qmonnet closed 1 year ago

qmonnet commented 1 year ago

It looks like I had some uncommitted changes in my repository when testing docs-to-ops.py for the last PR, and I failed to notice the missing comma. Let's address it.

Unrelated to the PR, the script passes on all kernel selftests files (tested at commit 5ee35abb461e, compiled with clang-16), without reporting any invalid instructions.

$ find ~/dev/linux/tools/testing/selftests/bpf -type f -name '*.bpf.o' | \
        xargs ~/dev/ebpf-docs/tools/ebpf-check/ebpf-check.py
<no output>

This means that we're unlikely to have any false positives (when looking for invalid instructions), although it doesn't tell if there's any false negative (invalid instructions we failed to detect).