search

ietf-wg-bpf / ebpf-docs

eBPF Standard Documentation
37 stars 5 forks source link

ISA: name of "opcode" field #72

Closed dthaler closed 4 months ago

dthaler commented 5 months ago

Section 2 has:

This is depicted in the following figure:

        basic_instruction
  .-----------------------------.
  |                             |
  code:8 regs:8 offset:16 imm:32 unused:32 imm:32

However the fields are named:

  opcode:8 src_reg:4 dst_reg:4 offset:16 imm:32 // In little-endian BPF.
  opcode:8 dst_reg:4 src_reg:4 offset:16 imm:32 // In big-endian BPF.

I.e., the figure should have "opcode" not "code".

dthaler commented 5 months ago

Fix proposed in https://mailarchive.ietf.org/arch/msg/bpf/y6SpFG1-y0G09lW-Ib5BbTf0jHo/

dthaler commented 4 months ago

Fixed in draft -01