ietf-wg-bpf / ebpf-docs

eBPF Standard Documentation
37 stars 5 forks source link

ISA: narrow the definition of legacy opcodes #96

Closed dthaler closed 4 months ago

dthaler commented 4 months ago

Currently for legacy packet access instructions, we deprecate an entire opcode. If some fields could instead be constrained to 0, it would leave more space un-reserved.

I think:

dthaler commented 4 months ago

Confirmed.

https://elixir.bootlin.com/linux/v6.8-rc1/source/kernel/bpf/verifier.c#L15101 has:

https://elixir.bootlin.com/linux/v6.8-rc1/source/kernel/bpf/verifier.c#L15127 checks that SRC = 0 for ABS.

dthaler commented 4 months ago

Proposed patch posted at https://mailarchive.ietf.org/arch/msg/bpf/1IajDsjWY2_43rX_qmloFkIADcw/

dthaler commented 4 months ago

Fixed in PR #99

dthaler commented 4 months ago

Fixed in draft -01