search

ietf-wg-httpapi / ratelimit-headers

Repository for IETF WG draft ratelimit-headers
Other
42 stars 4 forks source link

Fix: #64. Combine headers. #125

Closed ioggstream closed 1 year ago

ioggstream commented 1 year ago

This PR

darrelmiller commented 1 year ago

Hey @ioggstream ! Thanks for making this change. Was there consideration of using SFItem for limit rather than dictionary?

When I look at the follow, I immediately wonder why the two different approaches?

  RateLimit-Policy: 100;w=10
  RateLimit: limit=100, remaining=50, reset=5

Would the following be more natural?

  RateLimit-Policy: 100;w=10
  RateLimit: 100; remaining=50; reset=5
ioggstream commented 1 year ago

@darrelmiller since we are in greenfield now, we are free to experiment with different proposals. Since we are now assuming that adopters use SF-API, the idea was to play with https://github.com/ietf-wg-httpapi/ratelimit-headers/blob/main/test_ratelimit.py and identify a pattern where users might avoid for policy in policies and might be able to pick a policy directly.

If your colleagues have some ideas on that, it would be great!

darrelmiller commented 1 year ago

@ioggstream It would be great if we could get this PR merged as a baseline for future work on this spec. What do you think?

ioggstream commented 1 year ago

@darrelmiller merged reviews and fixed conflicts. If you approve it I'll merge.

ioggstream commented 1 year ago

@darrelmiller releasing -07