search

ietf-wg-httpapi / ratelimit-headers

Repository for IETF WG draft ratelimit-headers
Other
42 stars 4 forks source link

Limit and Quota terminology #31

Closed bridgetlane closed 3 years ago

bridgetlane commented 3 years ago

It seems in the context of this design limit and quota terminology mean the same thing, however the header name to represent quota is RateLimit-Limit, which stutters. Would RateLimit-Quota not be better because it seems to mean the same thing and avoids stuttering?

ioggstream commented 3 years ago

Well, RateLimit-Limit conveys the expiring-limit, which is expressed in terms of request-quota.

The name RateLimit-Quota makes me think more to a quota-policy than to request-quota or quota-units.

Since implementers already use X-RateLimit-Limit, with @unleashed we decided not to change field names.

WDYT to rename request-quota instead?

unleashed commented 3 years ago

One potential issue with request-quota is that the quota can be not directly related to the amount of requests. For example it could be time based, just to name a simple criteria, but there are multiple other potential factors that could affect the units returned that could be confused when using that name.

service-quota could arguably make for a better name.

unleashed commented 3 years ago

Not sure this should be closed by the PR, so feel free to reopen if that's not the case.

ioggstream commented 3 years ago

@bridgetlane thanks for your feedback! You're welcome to provide more! @unleashed to me it's fine! Good merge and good idea about service-* the new name is cool :)

bridgetlane commented 3 years ago

Thanks both! I think this is more clear.