ietf-wg-idr / draft-ietf-idr-bgp-ct

1 stars 2 forks source link

followup to #28 #29

Closed gregbo closed 1 year ago

gregbo commented 1 year ago

The changes I proposed in #28 reflect my review of roughly half of the draft. Time permitting, I will review the remainder of the draft, and propose additional changes if needed. I also have some additional issues to raise:

kalirajv commented 1 year ago

Thanks for the review Greg. Really appreciate it.

We will review and pull the suggested changes.

Thanks Kaliraj

On Fri, Aug 4, 2023, 10:30 PM Greg Skinner @.***> wrote:

The changes I proposed in #28 https://github.com/ietf-wg-idr/draft-ietf-idr-bgp-ct/pull/28 reflect my review of roughly half of the draft. Time permitting, I will review the remainder of the draft, and propose additional changes if needed. I also have some additional issues to raise:

  • I thought some text in the "Scaling Considerations" section suggested normative requirements, even though the normative directives weren't used. Perhaps you could explain why these considerations aren't normative.
  • In the Introduction (and several other places), there are references to options A, B, and C from RFC 4364. The (literal) text of RFC 4364 does not contain that wording, although there is router literature that makes the same references. Readers who are not familiar with this literature might be concerned about this, so I hope the change I made (adding "a.k.a. multi-AS") makes the reference clearer. Possibly, this is an issue to be addressed if a 4364bis is ever considered.

— Reply to this email directly, view it on GitHub https://github.com/ietf-wg-idr/draft-ietf-idr-bgp-ct/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEVH2QC4RYWZMVXRR67RRJTXTXLAVANCNFSM6AAAAAA3E7T2F4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kalirajv commented 1 year ago

These changes were pulled. Thanks for the text edits Greg.

Will close this issue.

Thanks Kaliraj