search

ietf-wg-jsonpath / draft-ietf-jsonpath-base

Development of a JSONPath internet draft
https://ietf-wg-jsonpath.github.io/draft-ietf-jsonpath-base/
Other
59 stars 20 forks source link

Use "JSON text" term #223

Closed glyn closed 2 years ago

glyn commented 2 years ago

... instead of "JSON document" or "JSON value".

"JSON value" is retained in some contexts where it refers to specific values i JSON rather than a whole document.

Fixes https://github.com/ietf-wg-jsonpath/draft-ietf-jsonpath-base/issues/210

cabo commented 2 years ago

JSON text is a sequence of characters, an unparsed piece of JSON for interchange, with newlines and backslashes and all that. JSONPath never looks at JSON texts. JSON value is the RFC 8259 term for what JSONPath looks at.

cabo commented 2 years ago

What should be done here is replacing all occurrences of "JSON document" with "JSON value".

glyn commented 2 years ago

@cabo Fixed with a force push. Sorry for misinterpreting the issue.

cabo commented 2 years ago

Terminology that would be nice to have could be "the JSON value that represents an entire JSON text". People are often using "JSON document" for that, but that is ambiguous between the serialization (JSON text) and the data (JSON value). If the text would really benefit from such a term, maybe we should coin it.

gregsdennis commented 2 years ago

This was opened and closed in just over 3 hours. I was asleep that entire time and had no chance to review.

Please be sure that PRs stay open for at least a day so they can be reviewed by everyone.

glyn commented 2 years ago

Thanks for the reminder @gregsdennis. Sorry I forgot.