ietf-wg-jsonpath / draft-ietf-jsonpath-base

Development of a JSONPath internet draft
https://ietf-wg-jsonpath.github.io/draft-ietf-jsonpath-base/
Other
58 stars 20 forks source link

Remove `BooleanType` as a type for consistent expression grammar #395

Closed gregsdennis closed 1 year ago

gregsdennis commented 1 year ago

This is an option for fixing the grammar issues explained in #387 around functions and their role in expressions.

A fallout of this is that $[?match(@.timezone, 'Europe/.*')] is not valid/well-formed.

gregsdennis commented 1 year ago

I think the usability of having to compare the result of match and search is poor

I agree that it's more clunky, but returning a value (thereby requiring the comparison) does have the advantage of providing support for $[?match(@.a, 'a.*')==@.b].

I'm not tied to it though.

cabo commented 1 year ago

The current status of the document has solved the clunkiness. I still don't know why we need this regression.

gregsdennis commented 1 year ago

The current status of the document has solved the clunkiness.

No. I will not debate this here. I've made the case perfectly clear in #387 over multiple comments that the current solution is subpar at best. The document is wrong.

cabo commented 1 year ago

Well, it seems the document is not describing the solution very well. Let's work on that.

gregsdennis commented 1 year ago

Well, it seems the document is not describing the solution very well. Let's work on that.

Make a proposal, but the solution is wrong. The document presents the solution. And that's why the document is wrong.

cabo commented 1 year ago

Well, it seems the document is not describing the solution very well. Let's work on that.

Make a proposal, but the solution is wrong. The document presents the solution. And that's why the document is wrong.

You have worked yourself into this fervor. I'm going to stop commenting on this issue.

cabo commented 1 year ago

This is superseded by #403.