search

ietf-wg-jsonpath / draft-ietf-jsonpath-base

Development of a JSONPath internet draft
https://ietf-wg-jsonpath.github.io/draft-ietf-jsonpath-base/
Other
58 stars 20 forks source link

Pr 428 #435

Closed cabo closed 1 year ago

cabo commented 1 year ago

This is based on main, as github doesn't seem to be able to base on timbray/main, which is the PR this is based on. Argh.

cabo commented 1 year ago

Please only look at https://github.com/ietf-wg-jsonpath/draft-ietf-jsonpath-base/pull/435/commits/e2c24f1a5a28493b48129fd05f43c0cb8d299685

glyn commented 1 year ago

Please only look at e2c24f1

Rebased on main after merging Tim's PR. There now remains just the salient commit.

cabo commented 1 year ago

OK, resolving with main fixed the "files changed" view.

glyn commented 1 year ago

Looks like you already did that, thanks.

On Thu, 16 Mar 2023, 18:01 cabo, @.***> wrote:

@.**** commented on this pull request.

In draft-ietf-jsonpath-base.md https://github.com/ietf-wg-jsonpath/draft-ietf-jsonpath-base/pull/435#discussion_r1139168717 :

@@ -256,7 +256,7 @@ Nodelist: does not require or assume any particular representation.

Parameter: -: Formal parameter that can take Arguments (actual parameters) in a function-expression. +: Formal parameter (of a function) that can take function arguments (actual parameters) in a function-expression.

Can you copy over this change to #428 https://github.com/ietf-wg-jsonpath/draft-ietf-jsonpath-base/pull/428? (I can't, because of the weird issue with PRs from "main" on "main".)

— Reply to this email directly, view it on GitHub https://github.com/ietf-wg-jsonpath/draft-ietf-jsonpath-base/pull/435#discussion_r1139168717, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXF2IGFLZNAE2W5LDDHYLW4NIQNANCNFSM6AAAAAAV5BPETY . You are receiving this because you modified the open/close state.Message ID: <ietf-wg-jsonpath/draft-ietf-jsonpath-base/pull/435/review/1344438900@ github.com>