search

ietf-wg-masque / draft-ietf-masque-quic-proxy

Other
12 stars 7 forks source link

terminology: change "server" to "target" #53

Closed ehaydenr closed 2 years ago

ehaydenr commented 2 years ago

Under terminology we have "Client", "Proxy", and "Target" defined, but for sockets and connection IDs, "server" is used instead of "target". The term "server" can be ambiguous - it's not immediately obvious whether it's referring to the proxy or the target.

Consider making it more specific: Server-facing socket -> Target-facing socket Server Connection ID -> Target Connection ID REGISTER_SERVER_CID -> REGISTER_TARGET_CID ACK_SERVER_CID -> ACK_TARGET_CID CLOSE_SERVER_CID -> CLOSE_TARGET_CID

tfpauly commented 2 years ago

@DavidSchinazi what do you think for this bikeshed?

DavidSchinazi commented 2 years ago

I think renaming from server to target would makes this clearer. The notion of a "target CID" does sound weird, but I think internal consistency is more important so going with target sounds best

LPardue commented 2 years ago

This might sound like a troll but I mean it sincerely

REGISTER_SERVER_CID -> REGISTER_TARGET_SERVER_CID ...

no one will ever get confused by that, and the name length doesn't affect the wire format

DavidSchinazi commented 2 years ago

I like REGISTER_TARGET_SERVER_CID, whether or not it's a troll