search

ietf-wg-scitt / draft-ietf-scitt-architecture

An Architecture for Trustworthy Digital Supply Chain Transparency Services
Other
11 stars 15 forks source link

Updated the first figure #266

Closed hannestschofenig closed 3 months ago

hannestschofenig commented 4 months ago

image

hannestschofenig commented 4 months ago

My biggest problem with the diagram is that it is not explained. It just falls out of the sky

SteveLasker commented 3 months ago

I took on the task of fixing the markdown, testing it locally, posting an image, ... I was able to revert several of the changes through the "resolve-conflicts" UX, but I would like to check the "services" changes that it renders properly I didn't get to it today, but will on Wednesday. ...please stand by... :)

SteveLasker commented 3 months ago

My biggest problem with the diagram is that it is not explained. It just falls out of the sky

Thanks, Hannes, that's a valid point. We may have lost some of the descriptive text along with the edits. Let's keep the diagram as-is, and work on additional text if needed.

SteveLasker commented 3 months ago

Latest changes, incorporating the feedback to date, which includes some formatting changes to the diagram, and text updates. image

yogeshbdeshpande commented 3 months ago

I think the diagram on the master/main is fine just needs some sentences of explanation text, around it.

Already the diagram is having quite a bit of components and flows. I would strictly request everyone to

  1. STOP editing the diagram
  2. Add text around it trying to explain the philosophy presented via a simple SCITT Architecture.
SteveLasker commented 3 months ago

Thanks, @yogeshbdeshpande, the diagram content has been reverted, only incorporating a few formatting changes. Hannes, and subsequent merged suggestions, added some additional text. Can you comment, suggest, and/or approve the current state of this PR. It does add more context.

yogeshbdeshpande commented 3 months ago

Thanks Steve, looking now!

yogeshbdeshpande commented 3 months ago

Done and Thanks again!