search

ietf-wg-scitt / draft-ietf-scitt-software-use-cases

Other
0 stars 5 forks source link

OS WGLC Review #11

Closed OR13 closed 6 months ago

OR13 commented 7 months ago

WGLC Review

rjb4standards commented 6 months ago

No objection to these proposed changes. Well done, Orie.

bobmartin3000 commented 6 months ago

Changes look good.

yogeshbdeshpande commented 6 months ago

@OR13 : As you are on a forked repo, I cannot make the changes which I have mentioned here : Directly.

Could you please merge my suggested .Nits so that I can merge the PR.

Thanks again for all the hardwork of reviewing the document!

OR13 commented 6 months ago

@yogeshbdeshpande done, thanks for your suggestions, I have applied them all.

This PR still requires at least 1 approval from code owners to be merged.

SteveLasker commented 6 months ago

@yogeshbdeshpande, as an author of the doc, can you LGTM to affirm you agree with the merged changes?

rjb4standards commented 6 months ago

I'll bite, what's an LGTM, Steve and is it available on Amazon Prime?

yogeshbdeshpande commented 6 months ago

@SteveLasker : I will fix the failing lints

yogeshbdeshpande commented 6 months ago

I'll bite, what's an LGTM, Steve and is it available on Amazon Prime?

LGTM=> Looks Good to Me :)