ietf-wg-uuidrev / rfc4122bis

revision to RFC4122
Other
57 stars 11 forks source link

Error in UUIDv8 Name-based Test Vector #129

Closed danielmarschall closed 1 year ago

danielmarschall commented 1 year ago

Hello,

At this example:

-------------------------------------------
field     bits value
-------------------------------------------
custom_a  48   0x401835fda627
ver        4   0x8
custom_b  12   0x627
var        2   b10
custom_c  62   b0, 0x73fed73f2bc5b2c
-------------------------------------------
total     128
-------------------------------------------
final: 401835fd-a627-870a-873f-ed73f2bc5b2c

The field custom_b should be 0x70a , not 0x627.

That being said, I noticed that the pull requests are marked as failed. I hope it is not too late for the changes

kyzer-davis commented 1 year ago

Yup, bad copy and paste on my part. Thanks for the double-check. Let me get that real fast.

Edit: I also noticed custom_c nees to have two 0s to be consistent with the other test-vectors. I did that over on https://github.com/ietf-wg-uuidrev/rfc4122bis/pull/128/commits/1bad8f0decd035938927c06ca92aacea6c3dddf3 as to not create merge conflict between my outstanding Branches/PRs