search

ietf-wg-uuidrev / rfc4122bis

revision to RFC4122
Other
57 stars 11 forks source link

Move UUIDv8 Examples out of Test Vectors #150

Closed ben221199 closed 1 year ago

ben221199 commented 1 year ago

As seen in #144 and #147, the examples of UUIDv8 are a big issue. We should do something about it and rewrite or remove them. The reason is that the examples can now be seen as some call to action to implement them literally, and that is not what they are for.

bradleypeabody commented 1 year ago

@ben221199 I'd like to see how #147 plays out, and then from there we can see if there is a new example that addresses the concerns from that issue, and/or if we want to remove or adjust any other examples. Regarding #144, I'm hoping that if we are not going to create UUIDv9 as an official hash-based UUID version right now, and just stick with UUIDv8 example(s), then it should simplify the matter, hopefully.

ben221199 commented 1 year ago

Okay clear. We will see.

kyzer-davis commented 1 year ago

Copying from the other thread:

I was planning to move the v8 "test vectors" to a new appendix titled "illustrative examples". Then put some leading text around how they are simply showing how one can use v8 and are not meant to be implemented (unless somebody really likes that logic.) and prefix with lots of "use at your own risk" text.

kyzer-davis commented 1 year ago

I have moved these out of test vectors and into their own appendix as per https://github.com/ietf-wg-uuidrev/rfc4122bis/issues/150#issuecomment-1731471692, and added lots of "here be dragons" text in https://github.com/ietf-wg-uuidrev/rfc4122bis/commit/020137452be6dcc225637f246319553e4c7ec384 and https://github.com/ietf-wg-uuidrev/rfc4122bis/commit/2a29aa0ef2b8f708ee38d3a849348bf9c2add8ef