search

ietf-wg-webtrans / draft-ietf-webtrans-http3

Internet Drafts for WebTransport
Other
40 stars 13 forks source link

Redo the version bump #128

Closed vasilvv closed 1 year ago

vasilvv commented 1 year ago

In a previous PR, I said that I bumped a SETTINGS parameter number to indicate the new draft version. Turns out, I accidentally changed the WEBTRANSPORT_MAX_SESSIONS codepoint instead.

This PR actually changes the correct one (ENABLE_WEBTRANSPORT). It also replaces "draft-06" with "draft-07", since draft-06 is not really implementable at this state.

DavidSchinazi commented 1 year ago

Can we have this PR also resolve #125 ? Let's avoid changing settings multiple times to reduce implementation churn

vasilvv commented 1 year ago

Can we have this PR also resolve #125 ? Let's avoid changing settings multiple times to reduce implementation churn

I don't think we should block solving the easy problem (which is me screwing up and changing the wrong number) on solving a related hard problem (which is merging two settings into one). I don't think there's implementation churn from this, since draft-06 is not really implementable (at least in backwards-compatible way) because of this problem.

ekinnear commented 1 year ago

I thought the other PR wasn't so much a mistake but rather was intentional, since we were talking about changing the setting. So to that end, I'd be tempted to just do #125 (happy to get a PR out for that shortly) and have this just update the text to point at the correct setting to look at.

ekinnear commented 1 year ago

Opened #129, so perhaps this would just keep the updates to the changelog and also note the change in setting name?