search

if-ai / ComfyUI-IF_AI_tools

ComfyUI-IF_AI_tools is a set of custom nodes for ComfyUI that allows you to generate prompts using a local Large Language Model (LLM) via Ollama. This tool enables you to enhance your image generation workflow by leveraging the power of language models.
https://ko-fi.com/impactframes
366 stars 27 forks source link

About breaking changes #25

Closed alonsojr1980 closed 1 month ago

alonsojr1980 commented 2 months ago

Hello! Every commit you make you break working workflows. I use ComfyUI's API a lot and it requires that all REQUIRED fields are sent with the POST json. Please, when you add new fields like "top_p" and "top_k", make them OPTIONAL with the OLLAMA's recommended default value. Thanks! image

if-ai commented 2 months ago

Sorry. I wasn't aware of that I'll be more careful, thank you. Maybe I can drag those as optional. Would that be okay?

alonsojr1980 commented 2 months ago

Sure! Don't forget to add the default values to those parameters in your "def describe_picture( )". Thank you very much!

if-ai commented 1 month ago

Okay I now move most of the parameters to optional and I am passing unto describe. I also unify the nodes into one and this looks to be more solid solution going forward to not break workflows the IFChatPrompt Node now will contain an SD mode.