search

ifactory-solutions / awesome-react-app

Always the latest version of "create-react-app" with awesome configurations (lint, commit lint, husk, editor config, etc)
MIT License
45 stars 7 forks source link

Create CONTRIBUTING and CODE_OF_CONDUCT #20

Closed harleo closed 6 years ago

harleo commented 6 years ago

Add contributing and code of conduct file for contributors

italopessoa commented 6 years ago

Hey @harleo. Could you please change your branches origin and base to develop?

so it will be like

commits into ifactory-solutions:develop from harleo:{any branch based on develop}

italopessoa commented 6 years ago

Hey @harleo, could you please create a new PR, using develop as the origin branch? We can't approve this PR, since it has some conflicts due to the fact you are using the master branch. We only use develop branch to PRs, we're working to make this clear to new contributors.

jvcjunior commented 6 years ago

Hey @harleo I'm sorry about the branch mess.. haha.. we are starting this project and we don't have a lot of experience. We are going to merge everything to master branch, and now on accept PR to our master branch as well. Folowwing this guy here: https://gist.github.com/Chaser324/ce0505fbed06b947d962

Maybe we could talk here: https://gitter.im/ifactory-open-source/awesome-react-app

Thanks for your patience and efforts! ❤️

harleo commented 6 years ago

All good guys, no worries. Do you want me to do another PR containing the two files later to the develop branch? Or are you going to approve this one?

PS: Don't forget about the contact error in the code of conduct file!