ifactory-solutions / awesome-react-app

Always the latest version of "create-react-app" with awesome configurations (lint, commit lint, husk, editor config, etc)
MIT License
45 stars 7 forks source link

Add git init and precommit hook for eslint #47

Closed ceejtron closed 6 years ago

ceejtron commented 6 years ago

As per #43 this adds precommit hooks for eslint. In addition, this adds a new question for initializing a git repository since precommit hooks can't be automatically set up unless a git repository has already been initialized.

italopessoa commented 6 years ago

Well done @ceejtron. Seems that is everything ok. Let's wait for the reviewers. Thank you for your contribution ❤️

paulonotz0r commented 6 years ago

Nice, @ceejtron! This is really cool!

In addition, can you add commit lint too? You can use the same as used on ifactory-solutions/inside-client#8.

Thank you for the contribution.

ceejtron commented 6 years ago

Added a check for .git as well as a commitlint hook

ceejtron commented 6 years ago

@jouderianjr I pushed the changes you asked for

jouderianjr commented 6 years ago

Awesome @ceejtron thanks for your work 💃