search

ifactory-solutions / awesome-react-app

Always the latest version of "create-react-app" with awesome configurations (lint, commit lint, husk, editor config, etc)
MIT License
45 stars 7 forks source link

Resolving #53 #54

Closed Polyneue closed 6 years ago

Polyneue commented 6 years ago

Adds in a step before logging a successful build that parses the README.md file and updates with given app name.

Let me know if this is what you were looking for!

italopessoa commented 6 years ago

Looks great @Polyneue. 💃

jouderianjr commented 6 years ago

Hey @Polyneue sorry for the late response.

I'm getting this error:

env: node\r: No such file or directory

are you using windows? windows by default breaks the line using \r\n, but the unix like system only uses \n.

You can use editorconfig in order to fix that 😄

Polyneue commented 6 years ago

@jouderianjr - I'm not on windows, running OSX with Node 8.1.3. Which version are you using to test the update?

Edit: I also saw that error when I first started working on the update, but it was related to not specifying a directory to write to. For example: awesome-react-app instead of awesome-react-app my-new-dir